Repository navigation
fix(sync): preserve synced progress in paused playback - #462
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
35d08de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ccce4ee.podnotes.pages.dev |
| Branch Preview URL: | https://fix-synced-progress-handoff.podnotes.pages.dev |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A paused player could overwrite newer synced progress with its held position. It now adopts synced progress when this device has not moved it. Active playback and unsaved local seeks, including native media controls, retain priority.
Fixes #461.
Scope
Covers paused progress and local seek ownership through the existing three-way merge. Episode selection and ended-episode restart behavior remain follow-ups.
Verification
npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test(2,424 tests),npm run test:tooling(13 tests),npm run docs:build.npm run test:e2eon fresh isolated vaults, Linux Obsidian 1.14.4 and 1.13.7, 139 tests each. Node v22.23.2; minimum-version run setPODNOTES_OBSIDIAN_APP=/opt/Obsidian/obsidian.Fixtures/Local Fixture.wavhandoff: master saved 12.077712 after sync delivered 45; this branch retained 45. Visible seek saved 30, native seek saved 42, and immediate native seek/save worked before media events. Full player, mini player and Media Session agree. Mobile platforms were not tested.npm run count:writes: master and branch both wrote 0 while idle, 2 after playback/pause, 3 after seek/flush.npm run size: 98,239 -> 98,324 gzip bytes (+85), below 100,000; 311,744 raw bytes.Mini player after sync
Release impact
No settings or data format changes, migration, public API changes, or URI changes.
Docs at release
In held #458,
sync.md, "Use PodNotes on two devices": remove step 2's stopped-time note and step 5's manual progress-bar correction. Replace the paragraph beginning "Step 5 matters" with the paused adoption rule and priority of active playback or an unsaved local seek. Keep waiting for sync and selecting the desired episode when another episode is loaded.In "Changes on two devices", replace the claim that every episode played since startup retains its local position with those same rules. In
mobile.md, the final "Limits on phones" bullet, remove noting and manually checking the stopped time. Keep pause, wait for sync, and the link to device handoff instructions.Note
Preserve synced progress in paused playback
PlayerControllerso a paused player adopts externally synced progress on restore, but a local seek, browser seek, or active playback always wins over a later syncnoteStoppedMovehelper and stopped-movement detection inonTimeUpdateandpersistin PlayerController.ts, so saves skip unchanged paused positions and record changed onessettlePausednow persists the position before publishing the paused stateMacroscope summarized 35d08de.